[RLlib] Add necessary fields to Base Envs, and BaseEnv wrapper classes #20832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
reviewed
Dec 1, 2021
|
They don't work yet, I am adding them in, which is why I made this a draft PR 😁 |
ok, ping after you are done 👍 |
gjoliver
reviewed
Dec 2, 2021
There was a problem hiding this comment.
still looks very nice. like the dict space design for multi-agent env.
just have one question, is it really worth it to have all the sub_environments() function take an additional as_dict parameter?
why not always return a dict?
it's not gonna make big difference when you use it, since you can simply .values() the returned dict.
6 tasks
avnishn
force-pushed
the
expand_base_env_api
branch
2 times, most recently
from
8e0ed14
to
030222f
Compare
|
looks great to me!! |
avnishn
force-pushed
the
expand_base_env_api
branch
from
a115b2d
to
e4a22f6
Compare
sven1977
reviewed
Dec 8, 2021
sven1977
reviewed
Dec 8, 2021
rllib/env/vector_env.py
Outdated
|
|
||
| @staticmethod | ||
| def _space_contains(space: gym.Space, x: MultiEnvDict) -> bool: | ||
| """Check if |
There was a problem hiding this comment.
Could you complete this docstring?
sven1977
changed the title
avnishn
force-pushed
the
expand_base_env_api
branch
from
830c036
to
f858585
Compare
gjoliver
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial commit. Adding observation_space
action_space, and a method for retrieving env_ids as
requirements to the BaseEnv Class
Will need to update for all of the other BaseEnv
wrappers
Why are these changes needed?
Base Envs are missing attributes that are necessary for validating them.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.